Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset() should not mark a driver "stopped" #69

Closed
dennisverspuij opened this issue Dec 9, 2016 · 3 comments
Closed

reset() should not mark a driver "stopped" #69

dennisverspuij opened this issue Dec 9, 2016 · 3 comments
Labels

Comments

@dennisverspuij
Copy link

$this->started is set to false in SessionTrait::reset(), while it should stay true according to \Behat\Mink\Driver\DriverInterface method description.
Instead SessionTrait::stop() should set it to false after calling $this->reset().

@jcalderonzumba
Copy link
Owner

@dennisverspuij: Problem solved 👍

@dennisverspuij
Copy link
Author

Awesome. Though now its only partially fixed because it should be set to false in stop() after calling $this->reset().

@jcalderonzumba
Copy link
Owner

@dennisverspuij You are definitely right, i missed that because since in stop() i was calling reset the started=false was done by reset. I'll fix it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants