Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bg image #18

Closed
marcomilone opened this issue Mar 4, 2022 · 4 comments
Closed

bg image #18

marcomilone opened this issue Mar 4, 2022 · 4 comments

Comments

@marcomilone
Copy link

First,
thanks for that package.
I was using my python script in the past, this one is way more comfortable.

The idea:

Default background is white, for targets that doesn't support transparency.

I'll like to have another command line option ( -bg ?)
to provide a secondary image.

That image, in my suggestion, should melt with the primary image, to compose the final image.

Ciaooo!

@jcalixte
Copy link
Owner

jcalixte commented Mar 27, 2022

Hi!

It's a good idea, to be sure I understand: you want to customize the fallback background color for, and only for, images that don't support transparent background?

Do you think the option can be named --fallback-background? I'll take a look of what can be done.

@marcomilone
Copy link
Author

Hello,
thanks for getting back.

Yes, that was the idea.

Just give a though, maybe is not so important,
the only image affected is favicon.ico as far as I see...?

Btw thanks for the package, works really well.

@jcalixte
Copy link
Owner

I think I can do the change this we, I'll keep you in touch.

@jcalixte
Copy link
Owner

jcalixte commented Apr 2, 2022

Hi Marco, the -b option is now available in 1.7.1 to provide a background color (simpler than providing a secondary image), so you can customize the favicon background. Hope it provides what you needed!

Cheers!

@jcalixte jcalixte closed this as completed Apr 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants