Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable forcing dashes on win32 #1

Closed
devmondo opened this issue May 31, 2019 · 4 comments
Closed

disable forcing dashes on win32 #1

devmondo opened this issue May 31, 2019 · 4 comments
Labels
feature New feature or request good first issue Good for newcomers

Comments

@devmondo
Copy link

Hi,
really awesome spinner and options, thanks alot for it :)

but can you please disable the enforcement of dashes spinners on win32, i am using windows 10 and it is perfectly capable of showing all symbols, i tested by manually commenting the if condition and it wokred.

thanks in advace :)

@jbcarpanelli jbcarpanelli added feature New feature or request good first issue Good for newcomers labels Jun 1, 2019
@jbcarpanelli
Copy link
Owner

Hello, @devmondo! Thanks for raising this 💪 . I wasn't 100% sure whether it was necessary to use a more conventional set of symbols for win32. I'm glad that it's not! I will fix it soon and release a new version afterwards. In the meantime, you can set the spinner animation manually as explained here (example included!).

@devmondo
Copy link
Author

devmondo commented Jun 1, 2019

thank @jcarpanelli for the prompt reply, but unless i am doing something wrong, the override option you mention i tried but it does not seem to work!

one note, you might want to make that option, in case someone I not using the latest windows 10 :)

@jbcarpanelli
Copy link
Owner

jbcarpanelli commented Jun 2, 2019

Hello there, @devmondo ! I finally kept the win32 validation, but thanks to this issue I realized that it wasn't possible to override the default win32 spinner, which was a bug 🐛.
I released v0.3.1 with a fix. You now should be able to override the spinner option as explained in the example mentioned in my previous answer! Both spinners are also being exported now, so you are able to do something like:

import { dots }, Spinnies from 'spinnies';

const spinnies = new Spinnies({ spinner: dots });

If you think your problem has been solved, please feel free to close this issue.

@devmondo
Copy link
Author

devmondo commented Jun 3, 2019

awesome work man!!!, it works perfectly, really loves your work there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants