Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add model manager for deleting old job executions. #58

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Add model manager for deleting old job executions. #58

merged 3 commits into from
Apr 3, 2019

Conversation

jcass77
Copy link
Owner

@jcass77 jcass77 commented Apr 3, 2019

Adds a new model manager for DjangoJobExecution to allow deleting old job executions, which can tally up quite quickly if multiple jobs have been scheduled with a high level of frequency.

  • Not sure why GitHub generated the large diff on the README: I only added one bullet point to describe the new feature.
  • I had to move the tests around a bit so that we could re-use some fixtures and mock objects centrally from conftest.py.

@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #58 into master will decrease coverage by 0.43%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #58      +/-   ##
==========================================
- Coverage   72.69%   72.25%   -0.44%     
==========================================
  Files           9        9              
  Lines         304      310       +6     
==========================================
+ Hits          221      224       +3     
- Misses         83       86       +3
Impacted Files Coverage Δ
django_apscheduler/models.py 81.81% <100%> (-8.19%) ⬇️
django_apscheduler/jobstores.py 73.79% <0%> (+2.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1e7c54...4081dfc. Read the comment docs.

@jarekwg jarekwg merged commit e9c3a6c into jcass77:master Apr 3, 2019
@jarekwg
Copy link
Collaborator

jarekwg commented Apr 3, 2019

Thanks for the PR. Would you be interested in helping maintain this package?

@jarekwg
Copy link
Collaborator

jarekwg commented Apr 3, 2019

Published in 0.3.0.

@jcass77 jcass77 deleted the enh/delete_old_job_executions branch July 16, 2020 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants