Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quick pull will lead to refresh twice or more times. #35

Open
Leaf585258 opened this issue Mar 21, 2017 · 7 comments
Open

Quick pull will lead to refresh twice or more times. #35

Leaf585258 opened this issue Mar 21, 2017 · 7 comments

Comments

@Leaf585258
Copy link

When I quickly pull the collectionView, the screen will refresh twice or more times. It seems that because the value of "loading" is not updated immediately.
if (scrollView.isDragging == false && loading == false) {
loading = true
}
These codes will be executed many times. Do you have a good method to solve it?

Thanks

@jcavar
Copy link
Owner

jcavar commented Apr 11, 2017

Hey, sorry for late reply. It makes sense what are you saying. I will try to fix this when I have some time.

@jcavar
Copy link
Owner

jcavar commented Apr 11, 2017

Or actually I am not sure, I can't reproduce that right now. Is it maybe related to this issue:
#12
Otherwise, could you send me project where this reproduces?

@Leaf585258
Copy link
Author

I had tried the methods mentioned in the issue #12, but it didn't solve the problem.

@jcavar
Copy link
Owner

jcavar commented Apr 30, 2017

Is it possible to send project demo project that reproduces this issue?

@nevinjethmalani
Copy link

I am having the same problem. I don't have a demo but it is happening more often in iOS 11 using swift 4.

@jcavar
Copy link
Owner

jcavar commented Oct 3, 2017

If you could provide demo project, failing test case or some more detailed steps how to reproduce this that would be great. I don't understand why would this happen and I am not able to reproduce this myself.

@KevinGong2013
Copy link

KevinGong2013 commented Nov 28, 2017

After some debug, this issue caused by: update scrollview's contentInset after added refresher to scrollview.
Please ensure set contentInset before add refresher.
Especially, if you add refresher in a common super viewController, double double check 🤓.
Sorry my poor english.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants