Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Complete Event -> Bug: onEnd fires at start #60

Closed
htopia opened this issue Jul 12, 2020 · 4 comments
Closed

Feature Request: Complete Event -> Bug: onEnd fires at start #60

htopia opened this issue Jul 12, 2020 · 4 comments
Assignees
Labels

Comments

@htopia
Copy link
Contributor

htopia commented Jul 12, 2020

Hi there,
First of all thank you so much for this simple and lightweight library, it's been super helpful!
I was wondering if we could get a complete event when an animation is finished.
It could also come in handy being able to trigger an event on a specific frame, so we can play sound effects and stuff like that.
Let me know if this is already supported.
Thanks again!

@jcblw
Copy link
Owner

jcblw commented Jul 12, 2020

@htopia thank you!

We do currently have an onEnd event. This only fire if you have stopLastFrame set to true. Does this allow you to do what you need or do you have something else in mind?

reference

@htopia
Copy link
Contributor Author

htopia commented Jul 13, 2020

hi @jcblw
Thank you for replying back.
onEnd sounded like just what I needed, however I just tried it and it seems to be getting triggered on start and end.
You can see the behavior here: https://codesandbox.io/s/cocky-jepsen-fgpz0

@jcblw
Copy link
Owner

jcblw commented Jul 13, 2020

@htopia interesting that's not good. Ok seems like a bug. Let's get that fixed.

@jcblw jcblw added the bug label Jul 13, 2020
@jcblw jcblw self-assigned this Jul 13, 2020
@jcblw jcblw changed the title Feature Request: Complete Event Feature Request: Complete Event -> Bug: onEnd fires at start Jul 13, 2020
@jcblw
Copy link
Owner

jcblw commented Jul 23, 2020

This should be all good now.

@jcblw jcblw closed this as completed Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants