-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
raw ca correction #162
Comments
First version is available for test in You also need to install librtprocess |
I just added a checkbox for ca correction. |
@heckflosse I noticed in the library set that CA correction can introduce artifacts where it looks like data is taken from the wrong image, hard to describe in words. Here is a set where this problem is very clear: |
@Beep6581 Please show a screenshot of the region in the image where the artifacts appear |
The same problem in the library shots around the light bulb: https://filebin.net/il7pzq83ly4miuru/karin_library_2_1-4_noca_crop.jpg?t=031xtx6b |
@Beep6581 I found the reason for the artifacts. Looking for a fix now... |
@heckflosse @Beep6581 Any news on this? Looking forward to CA correction in |
@Floessie I will continue after holidays |
W10 errors when compiling cacorrect branch with gcc 8.2.0
and a lot of warnings if you are interested |
I will fix that after holidays |
@heckflosse could you have a look please? |
This looks pretty amazing. Any word on it? |
@heckflosse could you direct me to what you think the reason behind the artefacts is? I want to help and would love a hint :) |
@fanckush I think the reason is, that the raw data is not white balanced. In RawTherapee we apply an auto whitebalance to the raw data before raw ca correction and demosaic and revert this scale after demosaic. Iirc this gave better raw ca correction and demosaic results and afaik that's the only difference atm between raw ca correction in RawTherapee and this hdrmerge branch. |
I just want to mention that there is some work by @CarVac and me in project https://github.com/CarVac/librtprocess
This work will also lead to allow usage of raw ca correction before merging the files in hdmerge....
Stay tuned...
The text was updated successfully, but these errors were encountered: