New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash with Fuji DR RAF #165
Comments
@Floessie Currently HDRMerge supports only files with one or three frames. But it should be easy to support two frames now as there is an example file available... Just try it ;-) https://github.com/jcelaya/hdrmerge/blob/master/src/ImageIO.cpp#L98 |
@Floessie The exr cameras also have a mode where the exposure of both frames is equal. In this case one can just combine them in RT (after adding some lines of code of course). Here's an example. Left is one frame, right is combination of both frames. Much less noise If you're interested, please open an issue in RawTherapee. The engine code is easy... |
@heckflosse Splendid! Ingo, thanks a lot. Fix confirmed, RAF developed, all fine! 👍
I think you mean the SN mode ("Signal/Noise"). Yes, I sometimes use it and would be a beneficiary. I have to dig through my archive to find such a RAF... |
@Floessie All exr RAF which are not made in DR mode should contain 2 frames with equal exposure. |
@heckflosse There are three modes: DR, SN and HR (which I never use). So even HR should contain two frames? |
@Floessie exactly |
@heckflosse I coincidentally have a stack (-1, 0, +1 EV) of DR RAFs, and had expected them to show up with six frames, now that you kindly fixed the DR case, but only got three. Wouldn't that be beneficial, to get the most out of the stack? I tried to work around it, by first merging the single DR shots and then combining the stack, but HDRMerge won't let me load its own DNGs. |
I wanted to point out #60 |
@heckflosse - it seems that not all EXR cameras produce the same kind of RAF file content. I have a Fujifilm FinePix S200EXR and took a triple shot in different explicit EXR modes. The results are as follows:
So I guess there is the following content:
A pity the example provided by @Floessie already expired. So I can't compare. |
OK, my mistake ... the camera stores two separate frames in the RAF only if it detects a sufficient contrast. Even if you force a specific contrast mode, the motive may still fit in the value range of only one frame. |
Interesting and good to know 👍 |
If you are curious, a few more EXR-DR samples Naming scheme:
You will notice that the contrast was moderate so that the 200% DR shot fit in only one raw frame. |
I went out today and shot several photos with high dynamic range. Hope you can use a few to improve handling of 2 frame raw images. BTW, I missed a guide how to use them correctly: Do I open one, or do I have to add a second copy? Without a copy, the preview is only green (1 layer), blue areas (layer 2) only appear with a stack of 2 times the dual frame RAF. |
As suggested by @heckflosse I started HDRMerge 0.5 as |
@LigH-de I also suggested to |
The GUI version (hdrmerge.exe) wrote nothing on the console. I tried the CLI version too:
|
Did you start it from console? |
Yes, I started the GUI version in a console. |
Ok, HDRMerge found only one frame. Nothing we can do about that, as we get the number of frames from libraw. |
Ah, ok, you're on windows. There console output from gui version might not work :( |
Well, you have plenty of test files in these archives. I remember that PlaneShift (an OpenSource multi-platform game) has similar issues that consoles don't work the same way in Linux and Windows. Here you may use DebugView messages as an alternative way to communicate with a developer. Or you would have to design your application as CLI type anyway and hand-weave the whole window handling. |
Nothing ... except maybe helping to improve libraw. |
For the Windows console thing we could use the code from RT where it works fine... |
Is there any more recent test version you can point at? If not, I may have to try if I can build it in MSYS2/MinGW. |
Now this version seems to work as expected. I see green and blue layer areas covering the image about 50:50. And the DNG looks quite credible in RawTherapee 5.7. |
Hi,
I was about to develop a RAF from my F600EXR in RT when to my surprise I learned that it contains two subframes, because it was taken in "Dynamic Range" mode. Thus, I fired up HDRMerge (master) to see if it would try to combine the frames. Unfortunately, I couldn't find it out, as it crashes immediately.
So here's the file in the hope that you can figure out what makes it so special. 😉
Best,
Flössie
The text was updated successfully, but these errors were encountered: