raise MissingDependencyError instead of aborting on missing dependency #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -42,6 +42,8 @@ class Pipeline | |||
| autoload :TextileFilter, 'html/pipeline/textile_filter' | |||
| autoload :TableOfContentsFilter, 'html/pipeline/toc_filter' | |||
| autoload :TextFilter, 'html/pipeline/text_filter' | |||
|
|
|||
| MissingDependencyError = Class.new(LoadError) | |||
There was a problem hiding this comment.
Could you switch this to this syntax:
class MissingDependencyError < LoadError; endIt's a bit easier for ctags, and editors to find the definition this way.
jch
added a commit
that referenced
this pull request
Jan 14, 2016
raise MissingDependencyError instead of aborting on missing dependency
|
👍 Thanks @parkr!!! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a0acb69
Fixes #240
/cc @jch for review.