Question - blocking behavior of getExpiredTokens()

[flozano]

A question about getExpiredTokens:

I see in the implementation that it opens a channel and wait for it to be closed (and, in the nio eventloopgroup threads, keep reading feedback entries and add them to expiredTokens).

However, I have seen sometimes APNS feedback service not closing the socket and leaving it open until there is some feedback to write, and only then close it (I had to add a read-timeout to java-apns library because of that).

How will pushy behave if that happens?

[jchambers]

Well, it looks like we'll just hang if that happens, but the "leave connection open until feedback is available" thing is new to me. Still, we should probably add a timeout to be safe.

[jchambers]

Opened a separate issue (see #15) for the actual timeout implementation. Closing this one as the question has technically been answered.