Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MaxMessageSize applies only to frames, not messages #20

Closed
jchampio opened this issue Nov 19, 2015 · 1 comment
Closed

MaxMessageSize applies only to frames, not messages #20

jchampio opened this issue Nov 19, 2015 · 1 comment
Assignees
@jchampio
Labels
bug fixed in master security

Comments

@jchampio
Copy link
Owner

The MaxMessageSize directive only rejects frames that are longer than the payload_limit. If an adversary sends a huge number of frames that are smaller than the MaxMessageSize, the module will happily try to buffer all of them.

Side note: why is MaxMessageSize not named WebSocketMaxMessageSize?
@jchampio jchampio self-assigned this Feb 9, 2016
@jchampio
Copy link
Owner Author

Fixed in 0.1.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jchampio jchampio

Labels
bug fixed in master security
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jchampio