Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hologram subprocess completes async with grunt task #8

Closed
akdetrick opened this issue Feb 24, 2015 · 2 comments
Closed

hologram subprocess completes async with grunt task #8

akdetrick opened this issue Feb 24, 2015 · 2 comments

Comments

@akdetrick
Copy link

https://github.com/jchild3rs/grunt-hologram/blob/master/tasks/hologram.js#L45

It looks like there's no guarantee that the hologram task has actually completed when grunt-hologram completes.

With larger sets of files for hologram to parse, it's likely that the node process won't complete before grunt begins the next task, making it difficult to use subsequent grunt tasks to manipulate hologram output.

cc @mattkime

@mattkime
Copy link

looks like there's already a pull request for this - #6

@jchild3rs
Copy link
Owner

Merged in and published at version 0.0.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants