Linux-part of #47: Implement per-device threads, don't use the KeyHandleMatcher #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcjones
reviewed
Nov 20, 2017
src/linux/mod.rs
Outdated
| return; | ||
| } | ||
|
|
||
| // Iterate the exlude list and see if there are any matches. |
| thread: Option<RunLoop>, | ||
| } | ||
|
|
||
| impl Transaction { |
There was a problem hiding this comment.
Feels like this could have a common interface with macos/transaction.rs, but perhaps that should be a follow-on after whatever happens to Windows.
There was a problem hiding this comment.
Indeed, I've been thinking about this too. There are tiny differences, e.g. the parameters for Device::new() and whether we call dev.is_u2f() or not but we can work around that. I agree that we should do this after converting Windows.
| @@ -108,7 +108,7 @@ impl PlatformManager { | |||
| u2f_is_keyhandle_valid(dev, &challenge, &application, key_handle) | |||
| .unwrap_or(false) /* no match on failure */ | |||
| }) | |||
| .collect::<Vec<&Vec<u8>>>(); | |||
| .collect::<Vec<_>>(); | |||
There was a problem hiding this comment.
Odd that this wasn't caught by the linter.
There was a problem hiding this comment.
Just a tiny cleanup. I hate having to be so specific :)
jcjones
approved these changes
Nov 20, 2017
… KeyHandleMatcher
ttaubert
force-pushed
the
no-khmatcher-linux
branch
from
245b8e0
to
3272176
Compare
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 20, 2017
…'t use KeyHandleMatcher r=jcj This patch rewrites the Linux backend to have a structure similar to the macOS one [1]. We'll have one thread per device, which means that a device that is stuck or unresponsive won't break other devices. [1] mozilla/authenticator-rs#52 Review: mozilla/authenticator-rs#56 mozilla/authenticator-rs@7d9f31a
JerryShih
pushed a commit
to JerryShih/gecko-dev
that referenced
this pull request
Nov 21, 2017
…'t use KeyHandleMatcher r=jcj This patch rewrites the Linux backend to have a structure similar to the macOS one [1]. We'll have one thread per device, which means that a device that is stuck or unresponsive won't break other devices. [1] mozilla/authenticator-rs#52 Review: mozilla/authenticator-rs#56 mozilla/authenticator-rs@7d9f31a
aethanyc
pushed a commit
to aethanyc/gecko-dev
that referenced
this pull request
Nov 22, 2017
…'t use KeyHandleMatcher r=jcj This patch rewrites the Linux backend to have a structure similar to the macOS one [1]. We'll have one thread per device, which means that a device that is stuck or unresponsive won't break other devices. [1] mozilla/authenticator-rs#52 Review: mozilla/authenticator-rs#56 mozilla/authenticator-rs@7d9f31a
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 2, 2019
…'t use KeyHandleMatcher r=jcj This patch rewrites the Linux backend to have a structure similar to the macOS one [1]. We'll have one thread per device, which means that a device that is stuck or unresponsive won't break other devices. [1] mozilla/authenticator-rs#52 Review: mozilla/authenticator-rs#56 mozilla/authenticator-rs@7d9f31a UltraBlame original commit: 066c5f6d20c759fcf65f8065010d32db34230e2e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 2, 2019
…'t use KeyHandleMatcher r=jcj This patch rewrites the Linux backend to have a structure similar to the macOS one [1]. We'll have one thread per device, which means that a device that is stuck or unresponsive won't break other devices. [1] mozilla/authenticator-rs#52 Review: mozilla/authenticator-rs#56 mozilla/authenticator-rs@7d9f31a UltraBlame original commit: 066c5f6d20c759fcf65f8065010d32db34230e2e
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 2, 2019
…'t use KeyHandleMatcher r=jcj This patch rewrites the Linux backend to have a structure similar to the macOS one [1]. We'll have one thread per device, which means that a device that is stuck or unresponsive won't break other devices. [1] mozilla/authenticator-rs#52 Review: mozilla/authenticator-rs#56 mozilla/authenticator-rs@7d9f31a UltraBlame original commit: 066c5f6d20c759fcf65f8065010d32db34230e2e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the Linux backend to look like the macOS one. See #52.