Supporting sparse #2
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
==========================================
- Coverage 98.09% 98.04% -0.05%
==========================================
Files 2 2
Lines 367 409 +42
==========================================
+ Hits 360 401 +41
- Misses 7 8 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for the PR! I was just expecting sparse_transpose but useful to have all these other functions supported too.
As well as minor comment below, if you could just add sparse to this file
https://github.com/jcmgray/autoray/blob/master/deps/requirements-py3.yml
then it can be included in the CI tests.
tests/test_autoray.py
Outdated
| @@ -48,6 +54,8 @@ def gen_rand(shape, backend, dtype='float64'): | |||
| def test_basic(backend, fn): | |||
| x = gen_rand((2, 3, 4), backend) | |||
| y = ar.do(fn, x) | |||
| if (backend is 'sparse') and (fn is 'sum'): | |||
There was a problem hiding this comment.
Using is for comparing strings works as a quirk of python, but should probably be avoided in favor of ==. (similarly for a few other places below).
|
I've pushed a few extra changes and am merging, thanks for the PR! |
@jcmgray Here is my attempt at implementing sparse support in autoray. Let me know if something needs to be changed significantly -- happy to help make this work.