Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindHover and bindFocus conflict on input #102

Closed
vibl opened this issue May 2, 2022 · 5 comments
Closed

bindHover and bindFocus conflict on input #102

vibl opened this issue May 2, 2022 · 5 comments
Labels

Comments

@vibl
Copy link

vibl commented May 2, 2022

When I use both bindHover and bindFocus on an input, they conflict: bindHover makes the popup close on blur, when the focus is still on the input.

A workaround could be to add a bindHoverOrFocus function.

But it might be better (if at all possible) to store the states hovered and focused somewhere in the hook and not close the popup if if one becomes false when the other is still true.

What do you think?

@jedwards1211
Copy link
Member

Yeah, sounds like that's the best solution. Will do!

@vibl
Copy link
Author

vibl commented May 2, 2022

Thanks for your fast answer!

@jedwards1211
Copy link
Member

okay I got bindHover + bindFocus working properly together 👍

@jedwards1211
Copy link
Member

🎉 This issue has been resolved in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@vibl
Copy link
Author

vibl commented May 2, 2022

Wow, the fix was also very fast! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants