Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in type definition paths #116

Closed
bmcbarron opened this issue Jan 4, 2023 · 2 comments
Closed

Error in type definition paths #116

bmcbarron opened this issue Jan 4, 2023 · 2 comments
Labels

Comments

@bmcbarron
Copy link

Hi! My TypeScript project depends on this project and was broken by the new type definitions in package.json. I've created a branch with the fixes here:

https://github.com/bmcbarron/material-ui-popup-state/tree/types-fix

I did not send a PR because I had to git commit --no-verify and git push --no-verify. On Windows, your lint command and pre-commit hooks do not run correctly. If you're concerned, you might want to apply the changes locally and run those checks yourself rather than merging directly.

Cheers, Brian

@jedwards1211
Copy link
Member

sorry for the delay, I missed the notification, will take a look!

@jedwards1211
Copy link
Member

🎉 This issue has been resolved in version 5.0.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants