Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make swap and fork options extend promisify option #78

Merged
merged 1 commit into from
Jul 9, 2019
Merged

fix: make swap and fork options extend promisify option #78

merged 1 commit into from
Jul 9, 2019

Conversation

conr2d
Copy link
Contributor

@conr2d conr2d commented Jul 9, 2019

index.d.ts uses the type of SpawnOptions and ForkOptions from child_process, it fails to compile with typescript due to not existing encoding property in option declaration.

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #78 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #78   +/-   ##
=======================================
  Coverage   96.87%   96.87%           
=======================================
  Files           1        1           
  Lines          64       64           
=======================================
  Hits           62       62           
  Misses          2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a898091...eb3c3ab. Read the comment docs.

@jedwards1211
Copy link
Member

cool, thanks!

@jedwards1211 jedwards1211 merged commit 8fe2d9e into jcoreio:master Jul 9, 2019
@jedwards1211
Copy link
Member

🎉 This PR is included in version 3.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants