refactor: make bevy_reflect optional (behind bevy-07 feature)
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcornaz
changed the title
bevy_reflect optionalbevy_reflect optional (behind bevy-07 feature)
jcornaz
added a commit
that referenced
this pull request
Jul 16, 2022
BREAKING CHANGE: Components no longer implement `Reflect` (see #80). It may be re-introduced if requested.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dependency
bevy_reflectis now optional (behind thebevy-07feature).I also removed the implementation of
Reflectfor the components that has been added eagerly without explicit need. And I am especially not enthusiast to implementReflectwithout a very compelling reason, due to how many technical details are leaked by such implementation (which prevents changing the implementation without breaking API)If you miss the
Reflectimplementation on benimator's components, you may open an issue. Please describe which component you'd need to implementReflectand why.