Skip to content
This repository has been archived by the owner on Nov 29, 2022. It is now read-only.

fix: acceleration still applied while PhysicsTime is paused #272

Merged
merged 1 commit into from May 19, 2022

Conversation

jcornaz
Copy link
Owner

@jcornaz jcornaz commented May 19, 2022

fix #251.

Thanks @cark for the bug report.

@jcornaz jcornaz self-assigned this May 19, 2022
@jcornaz jcornaz enabled auto-merge (squash) May 19, 2022 18:40
@jcornaz jcornaz merged commit 1e148ad into main May 19, 2022
@jcornaz jcornaz deleted the fix/acceleration-applied-when-paused branch May 19, 2022 18:45
@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 3.1.0 🎉

@cark
Copy link

cark commented May 27, 2022

Thanks !
I'll be testing this during next week.
While this is probably good for my use case, looking at the code I can't help but wonder about slow or fast motion.
I thought you would work this fix through the PhysicsTime. Though this is probably me misunderstanding the whole thing !

Anyways, good enough for me, thanks again.

@jcornaz
Copy link
Owner Author

jcornaz commented May 27, 2022

For slow/fast motion, rapier is supposed to handle it. As Heron is only the API, and rapier is responsible for the simulation itself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Acceleration still applied while PhysicsTime is paused
2 participants