New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc warning fix #385
doc warning fix #385
Conversation
@@ -237,7 +237,7 @@ This is the current list of error and warning codes: | |||
| E116 | unexpected indentation (comment) | | |||
+----------+----------------------------------------------------------------------+ | |||
+----------+----------------------------------------------------------------------+ | |||
| E121 (*^)| continuation line under-indented for hanging indent | | |||
| E121(\*^)| continuation line under-indented for hanging indent | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we still want it to be:
| E121 (\*^) |
Thanks for noticing that the *
wasn't appearing properly though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will require to re-align the entire table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All of the other errors have spaces between the (
and the error code. Re-aligning the table is quite simple to do if you use vim or sublime text
Well, using sublime + Table Editor did the trick. |
| W604 | backticks are deprecated, use 'repr()' | | ||
+----------+----------------------------------------------------------------------+ | ||
+------------+----------------------------------------------------------------------+ | ||
| code | sample message | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you center "code" and "sample message"?
sublimetext 3 + Table Editor = center "code" and "sample message". Does it matter? |
I'm not sure it's a blocker, but it's confusing to see as part of this change. It's also unclear if docutils/sphinx will render this differently as a result. It's also good etiquette to not make entirely unnecessary changes in a pull request, so there's that. |
Let me rephrase:
|
No description provided.