Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add netcdf-cxx4 to the stack #47

Closed
climbfuji opened this issue Feb 25, 2022 · 3 comments · Fixed by #38
Closed

Add netcdf-cxx4 to the stack #47

climbfuji opened this issue Feb 25, 2022 · 3 comments · Fixed by #38
Assignees

Comments

@climbfuji
Copy link
Collaborator

climbfuji commented Feb 25, 2022

JEDI uses netcdf-cxx4, which is not yet in the spack-stack environments.

@climbfuji climbfuji self-assigned this Feb 25, 2022
@edwardhartnett
Copy link
Collaborator

netcdf-cxx is not a great idea. It is not fully maintained and does not contain the latest changes to netcdf-c.

Instead, C++ programmers should always use the netcdf-c library directly.

If JEDI wants to use netcdf-cxx, I suggest that some JEDI programmer spend a few weeks working on netcdf-cxx to bring it up to date, and understand that will be an on-going effort as the C library changes.

For example, netcdf-cxx does not support the new quantize functions, which allow lossy compression of data...

@climbfuji
Copy link
Collaborator Author

Good points, and certainly that is something we should look into. For now, in order to build the stack so that it works for JEDI needs, we'll add netcdf-cxx4 as a dependency for the jedi-environments only (i.e. if you build the ufs-weather-model environment, you won't get it).

@climbfuji climbfuji changed the title Add netcdf-cxx to the stack Add netcdf-cxx4 to the stack Mar 1, 2022
@climbfuji
Copy link
Collaborator Author

@edwardhartnett I just realized that I mistakenly wrote netcdf-cxx in the issue, it's netcdf-cxx4. Your point still holds, we should migrate to netcdf-c, though. I created a corresponding issue in the soca-science repository, which is the only repository that I could find so far that uses netcdf-cxx4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants