Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test cases #3

Open
jcsilkey opened this issue Jun 4, 2018 · 0 comments
Open

Improve test cases #3

jcsilkey opened this issue Jun 4, 2018 · 0 comments

Comments

@jcsilkey
Copy link
Owner

jcsilkey commented Jun 4, 2018

Currently, the tests:

GuzzleRegistryTest::testGetClientWithCustomHandler
GuzzleRegistryTest::testGetClientWithCustomMiddleware
GuzzleRegistryTest::testGetClientWithCustomHandlerAndMiddleware

only verify that an instance of GuzzleHttp\Client is returned. They should verify that the configuration of the returned instance matches the configuration for the client.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcsilkey