Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Script for Quip #21

Closed
jessebeach opened this issue Feb 27, 2018 · 2 comments
Closed

New Script for Quip #21

jessebeach opened this issue Feb 27, 2018 · 2 comments

Comments

@jessebeach
Copy link

jessebeach commented Feb 27, 2018

  1. Put a main region around the document.
  2. Add a button to the beginning of main that removes/restores contenteditable from elements in the main content. There is an outstanding question as to what it will take to force browsers to update their accessibility tree after doing that. Just removing the attribute is not good enough based on Jesse’s bookmarklet. We could leave the restore function off it refreshing the page restored it.
  3. Wrap comments in role=article.
  4. Put button role on the elements that expand comments or expand the comments.
  5. Put a label on each comment article that says who did what when, e.g., Jesse commented 1 day ago.
  6. It would also be really helpful if there were some way we could make the script help with the export process. Resolving that may be quite a bit more tricky. The menu elements have the right roles, but they don’t reliably respond to screen reader click events and never get DOM focus.
@plinehan
Copy link

plinehan commented Oct 9, 2018

Hey @jessebeach!

Quip has made a bunch of accessibility improvements since you created this issue, and I think most of your requests are now in the product itself!

We have reasonable roles for the vast majority of the document and chat UI, you can disable contenteditable with the Ctrl+Alt+Z (Cmd+Opt+Z on Mac) keyboard shortcut, icon-only buttons are now properly aria-labelled, and menus are keyboard navigable for allowing easy export.

Our accessibility support article has more details: https://www.quipsupport.com/hc/en-us/articles/360016095371-Quip-Accessibility-

We're still actively working on improving accessibility, so this is just the start!

@jessebeach
Copy link
Author

@plinehan Agree, the work you and your teammates have done is commendable. I agree that this script is no longer necessary. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants