Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with group_by_ when using make_phy_df function #9

Closed
thessyed opened this issue Sep 30, 2019 · 6 comments
Closed

Issue with group_by_ when using make_phy_df function #9

thessyed opened this issue Sep 30, 2019 · 6 comments

Comments

@thessyed
Copy link
Collaborator

Hi,

When I attempt to use make_phy_df from exploratory_graphics.R, the following error is returned:

Error in group_by_(., .dots = metacols) :
could not find function "group_by_"

Seems like the function was removed?

Thanks in advance for help with this and please let me know if further information is required

@bbolker
Copy link
Collaborator

bbolker commented Sep 30, 2019

I'm not sure offhand what's going on, but what happens if you explicitly library(dplyr) first? (FWIW group_by_ is soft-deprecated and this should probably transition to using the new {{}} ... ??? group_by_at() might be useful.

@JCSzamosi
Copy link
Owner

User wasn't loading the package, therefore didn't have dplyr available.

@bbolker
Copy link
Collaborator

bbolker commented Oct 1, 2019

I haven't looked at this carefully at all, but do you need to thinking about Depends: or Imports: + re-exporting?

@JCSzamosi
Copy link
Owner

I don't think so. The package already imports dplyr. The problem was that Saad was just sourcing the exploratory_graphics.R file.

@bbolker
Copy link
Collaborator

bbolker commented Oct 1, 2019

oh, OK. (Misunderstood your comment above, sorry.)

@JCSzamosi
Copy link
Owner

I was vague. I'm not used to anyone other than me reading these threads :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants