Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor issues on mobile #620

Open
jcubic opened this issue Aug 31, 2020 · 6 comments
Open

Cursor issues on mobile #620

jcubic opened this issue Aug 31, 2020 · 6 comments

Comments

@jcubic
Copy link
Owner

jcubic commented Aug 31, 2020

Issue summary

Cursor position don't work 100% correctly.

  1. One issue is that opacity on content editable don't work properly.
  2. The editable area is not exactly in same place as command line.
  3. When there are no command, cursor is at the beginning of prompt.
  4. When cmd is not at bottom, the cmd and editable area don't overlap.
  5. Adding shift+enter cursor don't move to next line.

Steps to reproduce

Demo https://terminal.jcubic.pl/lips.php

First issue is solved in demo that add extra css.

Browser and OS

Android

@jcubic jcubic added the Bug label Aug 31, 2020
@noon2a
Copy link

noon2a commented Feb 8, 2021

.

@jcubic
Copy link
Owner Author

jcubic commented Feb 8, 2021

@noon2a if you want to be notified about issue there is subscribe button on the right.

@rabbithops
Copy link

Your original issue references Andoid, but this is a problem on iOS as well.
With enough repeated clicks near the cursor, I can get the keyboard to come up, but the clickable area is either too small or not placed correctly.
I have a lot of different iOS devices and can assist with QA if needed.

@jcubic
Copy link
Owner Author

jcubic commented Jun 30, 2021

@rabbithops Yes, it's the same code I don't expect on iOS to work differently, when the fix will be added and tested on Android it should automagically work on iOS too.

@jcubic
Copy link
Owner Author

jcubic commented Jun 30, 2021

@rabbithops if you have a real iOS device you can check one thing. I was wondering how it works with the new Safari padding thing. explained in this article: https://webkit.org/blog/7929/designing-websites-for-iphone-x/

Can you create a screenshot how the full-screen terminal looks like on iPhone? I have access to BrowserStack but it doesn't look like real iPhone.

@jcubic
Copy link
Owner Author

jcubic commented Jul 5, 2021

Fix the demo, it was using some old file that caused JS error and white page.

@jcubic jcubic added the mobile label Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants