Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exception in greeting function break terminal when inside SVG #767

Closed
1 task
jcubic opened this issue Mar 26, 2022 · 1 comment
Closed
1 task

Exception in greeting function break terminal when inside SVG #767

jcubic opened this issue Mar 26, 2022 · 1 comment

Comments

@jcubic
Copy link
Owner

jcubic commented Mar 26, 2022

Issue summary

When greeting function throw exception it show stack trace but break --pixel density calculation from #744

Expected behavior

The stack trace is visible with correct pixel-density

Actual behavior

The stack trace is visible but the size is broken.

Steps to reproduce

  1. Use devel version with SVG demo and this code
$('#term').terminal($.noop, {
   greetings() {
     dontExist();
   }
});

TODO

  • Test all possible functions if exception doesn't break anything else
@jcubic jcubic added the Bug label Mar 27, 2022
@jcubic jcubic added this to the 2.33.0 milestone Mar 27, 2022
@jcubic
Copy link
Owner Author

jcubic commented Mar 27, 2022

Cannot reproduce it anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant