Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong error messages when calling numerical operators on different types #128

Closed
jcubic opened this issue Feb 15, 2021 · 1 comment
Closed

Wrong error messages when calling numerical operators on different types #128

jcubic opened this issue Feb 15, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@jcubic
Copy link
Collaborator

jcubic commented Feb 15, 2021 •
edited

It seems that are some inconstancy in typechecking:


lips> (= "xx" 10)
You can't create LNumber from string

Wrong error message probably the function don't check types so error came from LNumber.

lips> (+ 1 "x")
Expecting number, got string

Missing in expression `+`

Another not related issue is that "Error" is missing in REPL.
@jcubic jcubic added the bug Something isn't working label Feb 15, 2021
jcubic added a commit that referenced this issue Feb 15, 2021
@jcubic
fix typechecking of number operators + fix err messages #128
db7e16c
@jcubic
Copy link
Collaborator Author

jcubic commented Feb 15, 2021

It will be hard to add ``in expression `+``` because operation are generic higher order functions. The rest of the issue was fixed.

@jcubic jcubic closed this as completed Feb 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jcubic