Retry coroutines #37
Retry coroutines #37
Conversation
|
@Haypo I'd love to have your opinion on this patch! |
|
cc @jpic |
|
Grün :) |
| @@ -55,6 +58,11 @@ | |||
|
|
|||
| from tenacity import _utils | |||
|
|
|||
| if sys.version_info > (3, 4): | |||
There was a problem hiding this comment.
asyncio is part of Python stdlib since Python 3.4, so it should be >=, no?
It is possible to install it as a third party module on Python 3.3, but I'm not sure that it's worth it to support Python 3.3 (it's no more used, and it wasn't never very popular).
There was a problem hiding this comment.
>>> (3, 4, 0) > (3, 4)
TrueAs you wish.
There was a problem hiding this comment.
Pyt3.3 is not tested on travis for this project :)
|
|
||
|
|
||
| @asyncio.coroutine | ||
| def call(self, fn, *args, **kwargs): |
There was a problem hiding this comment.
"self" is a bad parameter name if it's not a method but a function. Call it maybe retrying?
There was a problem hiding this comment.
Yep, retrying is good.
|
@Haypo do you mean the test case is not effective ? |
|
@bersace if you squash your fixup commits that will make that easier to review first. If the code without iterator is simpler, give it a try in another PR, that might be interesting or help us review both PR :) |
|
@jd let's try this. |
|
@jd rebased. One-commit PR to add retry on coroutines :) |
| elif isinstance(do, DoSleep): | ||
| result = NO_RESULT | ||
| exc_info = None | ||
| yield from asyncio.sleep(do) |
There was a problem hiding this comment.
So you're really ignoring self.sleep?
There was a problem hiding this comment.
self.sleep is not in BaseRetrying but (Sync)Retrying. If you want, i can add a sleep=asyncio.sleep __init__() argument.
There was a problem hiding this comment.
You're right, I forgot that. I don't think it makes sense to have a different sleep here since it's tied to asyncio, so that's good. :)
|
Green \o/ |
|
@jd thanks. Do you plan a release soon ? :) |
|
@bersace just pushed 3.6.0 |
Hi,
This PR ports rholder/retrying#64 to tenacity. Thanks for the fork. The codebase is really clean.
It's a bit tricky to implement retry on coroutines. I did this by extracting the calling (aka attempt) and sleep logic from the retry control loop. This is done by using a generator. The control loop generate instructions (attempt, sleep or return), it's up to the wrapping code to do the actual IO, asynchronously or not.
I'm actually not very proud of this. Supporting old python versions and sync/async is a bit hackish. I'd be glad to hear your opinion on this contribution. Until it's mergeable, i wish :)
Regards,