Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables: No way to set raw #3541

Closed
2 tasks done
glensc opened this issue Feb 16, 2024 · 1 comment · Fixed by #3542
Closed
2 tasks done

Variables: No way to set raw #3541

glensc opened this issue Feb 16, 2024 · 1 comment · Fixed by #3542
Labels
released This issue/pull request has been released. type:types Adding or enhancing typescript types

Comments

@glensc
Copy link
Contributor

glensc commented Feb 16, 2024

Description

Some attributes are readable, but not settable:

{
  variable_type: 'env_var',
  key: 'TEST',
  value: 'false',
  protected: false,
  masked: false,
  raw: true,
  environment_scope: '*',
  description: null
}

missing:

  • raw
  • description

Proposal

It's this place in final code, I suppose:

interface ProjectVariables<C extends boolean = false> extends ResourceVariables<C> {
    all<E extends boolean = false, P extends PaginationTypes = 'offset'>(projectId: string | number, options?: Sudo & ShowExpanded<E> & PaginationRequestOptions<P>): Promise<GitlabAPIResponse<ProjectVariableSchema[], C, E, P>>;
    create<E extends boolean = false>(projectId: string | number, key: string, value: string, options?: {
        variableType?: VariableType;
        protected?: boolean;
        masked?: boolean;
        environmentScope?: string;
    } & Sudo & ShowExpanded<E>): Promise<GitlabAPIResponse<ProjectVariableSchema, C, E, void>>;

Checklist

  • I have checked that this is not a duplicate issue.
  • I have read the documentation.
@jdalrymple
Copy link
Owner

🚀 Issue was released in 39.34.3 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. type:types Adding or enhancing typescript types
Projects
None yet
2 participants