Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectRemoteMirrors delete endpoint targets project_aliases #3549

Closed
vitamindck opened this issue Mar 6, 2024 · 1 comment
Closed

ProjectRemoteMirrors delete endpoint targets project_aliases #3549

vitamindck opened this issue Mar 6, 2024 · 1 comment
Labels
type:bug Changes fix a minor bug

Comments

@vitamindck
Copy link
Contributor

vitamindck commented Mar 6, 2024

The linked code targets a project_aliases endpoint instead of remote_mirrors, which appears to be incorrect based on the context of the file.

remove<E extends boolean = false>(

I think the remove function should be similar to what I pasted below after converted to JS.

remove(projectId, mirrorId, options) {
  return RequestHelper.del()(
    this, 
    endpoint`projects/${projectId}/remote_mirrors/${mirrorId}`, 
    options
  );
}

pull request #3550 is typescript

@vitamindck
Copy link
Contributor Author

fixed with #3550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Changes fix a minor bug
Projects
None yet
Development

No branches or pull requests

2 participants