Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccessTokenSchema.token is not optional when create #3553

Closed
2 tasks done
ArnaudTA opened this issue Mar 8, 2024 · 2 comments · Fixed by #3554
Closed
2 tasks done

AccessTokenSchema.token is not optional when create #3553

ArnaudTA opened this issue Mar 8, 2024 · 2 comments · Fixed by #3554
Labels
released This issue/pull request has been released. type:enhancement type:types Adding or enhancing typescript types

Comments

@ArnaudTA
Copy link
Contributor

ArnaudTA commented Mar 8, 2024 •
edited

Description

Hello,
I noticed AccessTokenSchema has optional token key, it makes sense when you use api.GroupAccessTokens.show but not on api.GroupAccessTokens.create method.

It's not urgent or important but if you can fix it would be nice :)

Possible solutions
I don't have solution that meet your code quality, my ideas are pretty ugly :/

Checklist

  • I have checked that this is not a duplicate issue.
  • I have read the documentation.
@jdalrymple jdalrymple added type:enhancement type:types Adding or enhancing typescript types labels Mar 8, 2024
@jdalrymple jdalrymple mentioned this issue Mar 8, 2024
Merged
@ArnaudTA
Copy link
Contributor Author

ArnaudTA commented Mar 8, 2024

Thank you very much <3

@jdalrymple
Copy link
Owner

🚀 Issue was released in 40.0.0 🚀

@jdalrymple jdalrymple added the released This issue/pull request has been released. label Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released This issue/pull request has been released. type:enhancement type:types Adding or enhancing typescript types
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updating Access Token API wrapper jdalrymple/gitbeaker
2 participants
@jdalrymple @ArnaudTA