fix: Removing required options object in a few of the API methods (#505)

jdalrymple · Dec 4, 2019 · b709ef6 · b709ef6
1 parent 55e688c
commit b709ef6
Show file tree

Hide file tree

Showing 39 changed files with 46 additions and 46 deletions.
diff --git a/src/core/services/CommitDiscussions.ts b/src/core/services/CommitDiscussions.ts
@@ -2,7 +2,7 @@ import { ResourceDiscussions } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class CommitDiscussions extends ResourceDiscussions {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'commits', options);
   }
 }
diff --git a/src/core/services/EpicDiscussions.ts b/src/core/services/EpicDiscussions.ts
@@ -2,7 +2,7 @@ import { ResourceDiscussions } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class EpicDiscussions extends ResourceDiscussions {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', 'epics', options);
   }
 }
diff --git a/src/core/services/EpicNotes.ts b/src/core/services/EpicNotes.ts
@@ -2,7 +2,7 @@ import { ResourceNotes } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class EpicNotes extends ResourceNotes {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', 'epics', options);
   }
 }
diff --git a/src/core/services/GitLabCIYMLTemplates.ts b/src/core/services/GitLabCIYMLTemplates.ts
@@ -2,7 +2,7 @@ import { ResourceTemplates } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GitLabCIYMLTemplates extends ResourceTemplates {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('gitlab_ci_ymls', options);
   }
 }
diff --git a/src/core/services/GitignoreTemplates.ts b/src/core/services/GitignoreTemplates.ts
@@ -2,7 +2,7 @@ import { ResourceTemplates } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GitignoreTemplates extends ResourceTemplates {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('gitignores', options);
   }
 }
diff --git a/src/core/services/GroupAccessRequests.ts b/src/core/services/GroupAccessRequests.ts
@@ -2,7 +2,7 @@ import { ResourceAccessRequests } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupAccessRequests extends ResourceAccessRequests {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupBadges.ts b/src/core/services/GroupBadges.ts
@@ -2,7 +2,7 @@ import { ResourceBadges } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupBadges extends ResourceBadges {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupCustomAttributes.ts b/src/core/services/GroupCustomAttributes.ts
@@ -2,7 +2,7 @@ import { ResourceCustomAttributes } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupCustomAttributes extends ResourceCustomAttributes {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupIssueBoards.ts b/src/core/services/GroupIssueBoards.ts
@@ -2,7 +2,7 @@ import { ResourceIssueBoards } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupIssueBoards extends ResourceIssueBoards {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupLabels.ts b/src/core/services/GroupLabels.ts
@@ -2,7 +2,7 @@ import { BaseServiceOptions } from '../infrastructure';
 import { ResourceLabels } from '../templates';
 
 export class GroupLabels extends ResourceLabels {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupMembers.ts b/src/core/services/GroupMembers.ts
@@ -2,7 +2,7 @@ import { ResourceMembers } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupMembers extends ResourceMembers {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupMilestones.ts b/src/core/services/GroupMilestones.ts
@@ -2,7 +2,7 @@ import { ResourceMilestones } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupMilestones extends ResourceMilestones {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/GroupVariables.ts b/src/core/services/GroupVariables.ts
@@ -2,7 +2,7 @@ import { ResourceVariables } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class GroupVariables extends ResourceVariables {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('groups', options);
   }
 }
diff --git a/src/core/services/IssueAwardEmojis.ts b/src/core/services/IssueAwardEmojis.ts
@@ -2,7 +2,7 @@ import { ResourceAwardEmojis } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class IssueAwardEmojis extends ResourceAwardEmojis {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('issues', options);
   }
 }
diff --git a/src/core/services/IssueDiscussions.ts b/src/core/services/IssueDiscussions.ts
@@ -2,7 +2,7 @@ import { ResourceDiscussions } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class IssueDiscussions extends ResourceDiscussions {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'issues', options);
   }
 }
diff --git a/src/core/services/IssueNotes.ts b/src/core/services/IssueNotes.ts
@@ -2,7 +2,7 @@ import { ResourceNotes } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class IssueNotes extends ResourceNotes {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'issues', options);
   }
 }
diff --git a/src/core/services/Jobs.ts b/src/core/services/Jobs.ts
@@ -144,7 +144,7 @@ export class Jobs extends BaseService {
   showPipelineJobs(
     projectId: string | number,
     pipelineId: number,
-    options: { scope: JobScope } & Sudo,
+    options?: { scope?: JobScope } & Sudo,
   ) {
     const [pId, ppId] = [projectId, pipelineId].map(encodeURIComponent);
 

diff --git a/src/core/services/Labels.ts b/src/core/services/Labels.ts
@@ -2,7 +2,7 @@ import { BaseServiceOptions } from '../infrastructure';
 import { ResourceLabels } from '../templates';
 
 export class Labels extends ResourceLabels {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/LicenceTemplates.ts b/src/core/services/LicenceTemplates.ts
@@ -2,7 +2,7 @@ import { ResourceTemplates } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class LicenceTemplates extends ResourceTemplates {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('licences', options);
   }
 }
diff --git a/src/core/services/Markdown.ts b/src/core/services/Markdown.ts
@@ -1,7 +1,7 @@
 import { BaseService, RequestHelper, Sudo } from '../infrastructure';
 
 export class Markdown extends BaseService {
-  render(text: string, options: { gfm?: string; project?: string | number } & Sudo) {
+  render(text: string, options?: { gfm?: string; project?: string | number } & Sudo) {
     return RequestHelper.post(this, 'markdown', { text, ...options });
   }
 }
diff --git a/src/core/services/MergeRequestAwardEmojis.ts b/src/core/services/MergeRequestAwardEmojis.ts
@@ -2,7 +2,7 @@ import { ResourceAwardEmojis } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class MergeRequestAwardEmojis extends ResourceAwardEmojis {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('merge_requests', options);
   }
 }
diff --git a/src/core/services/MergeRequestDiscussions.ts b/src/core/services/MergeRequestDiscussions.ts
@@ -2,7 +2,7 @@ import { ResourceDiscussions } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class MergeRequestDiscussions extends ResourceDiscussions {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'merge_requests', options);
   }
 }
diff --git a/src/core/services/MergeRequestNotes.ts b/src/core/services/MergeRequestNotes.ts
@@ -2,7 +2,7 @@ import { ResourceNotes } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class MergeRequestNotes extends ResourceNotes {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'merge_requests', options);
   }
 }
diff --git a/src/core/services/MergeRequests.ts b/src/core/services/MergeRequests.ts
@@ -109,7 +109,7 @@ export class MergeRequests extends BaseService {
   approve(
     projectId: string | number,
     mergerequestIId: number,
-    options: { sha?: string } & BaseRequestOptions,
+    options?: { sha?: string } & BaseRequestOptions,
   ) {
     const [pId, mIId] = [projectId, mergerequestIId].map(encodeURIComponent);
 
@@ -118,7 +118,7 @@ export class MergeRequests extends BaseService {
 
   approvals(
     projectId: string | number,
-    { mergerequestIId, ...options }: { mergerequestIId?: number } & BaseRequestOptions,
+    { mergerequestIId, ...options }: { mergerequestIId?: number } & BaseRequestOptions = {},
   ) {
     const pId = encodeURIComponent(projectId);
 
@@ -137,7 +137,7 @@ export class MergeRequests extends BaseService {
   approvalState(
     projectId: string | number,
     mergerequestIId: number,
-    options: { sha?: string } & BaseRequestOptions,
+    options?: { sha?: string } & BaseRequestOptions,
   ) {
     const [pId, mIId] = [projectId, mergerequestIId].map(encodeURIComponent);
 
@@ -152,7 +152,7 @@ export class MergeRequests extends BaseService {
     projectId: string | number,
     approverIds: number[],
     approverGroupIds: (string | number)[],
-    { mergerequestIId, ...options }: { mergerequestIId?: number } & BaseRequestOptions,
+    { mergerequestIId, ...options }: { mergerequestIId?: number } & BaseRequestOptions = {},
   ) {
     const pId = encodeURIComponent(projectId);
 
@@ -226,7 +226,7 @@ export class MergeRequests extends BaseService {
 
   editApprovals(
     projectId: string | number,
-    { mergerequestIId, ...options }: { mergerequestIId?: number } & BaseRequestOptions,
+    { mergerequestIId, ...options }: { mergerequestIId?: number } & BaseRequestOptions = {},
   ) {
     const pId = encodeURIComponent(projectId);
 

diff --git a/src/core/services/Namespaces.ts b/src/core/services/Namespaces.ts
@@ -5,7 +5,7 @@ export class Namespaces extends BaseService {
     return RequestHelper.get(this, 'namespaces', options);
   }
 
-  show(namespaceId: string | number, options: { search?: string } & Sudo) {
+  show(namespaceId: string | number, options?: { search?: string } & Sudo) {
     const nId = encodeURIComponent(namespaceId);
 
     return RequestHelper.get(this, `namespaces/${nId}`, options);

diff --git a/src/core/services/ProjectAccessRequests.ts b/src/core/services/ProjectAccessRequests.ts
@@ -2,7 +2,7 @@ import { ResourceAccessRequests } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectAccessRequests extends ResourceAccessRequests {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProjectBadges.ts b/src/core/services/ProjectBadges.ts
@@ -2,7 +2,7 @@ import { ResourceBadges } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectBadges extends ResourceBadges {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProjectCustomAttributes.ts b/src/core/services/ProjectCustomAttributes.ts
@@ -2,7 +2,7 @@ import { ResourceCustomAttributes } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectCustomAttributes extends ResourceCustomAttributes {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProjectIssueBoards.ts b/src/core/services/ProjectIssueBoards.ts
@@ -2,7 +2,7 @@ import { ResourceIssueBoards } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectIssueBoards extends ResourceIssueBoards {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProjectMembers.ts b/src/core/services/ProjectMembers.ts
@@ -2,7 +2,7 @@ import { ResourceMembers } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectMembers extends ResourceMembers {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProjectMilestones.ts b/src/core/services/ProjectMilestones.ts
@@ -2,7 +2,7 @@ import { ResourceMilestones } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectMilestones extends ResourceMilestones {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProjectSnippetAwardEmojis.ts b/src/core/services/ProjectSnippetAwardEmojis.ts
@@ -2,7 +2,7 @@ import { ResourceAwardEmojis } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectSnippetAwardEmojis extends ResourceAwardEmojis {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('issues', options);
   }
 }
diff --git a/src/core/services/ProjectSnippetDiscussions.ts b/src/core/services/ProjectSnippetDiscussions.ts
@@ -2,7 +2,7 @@ import { ResourceDiscussions } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectSnippetDiscussions extends ResourceDiscussions {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'snippets', options);
   }
 }
diff --git a/src/core/services/ProjectSnippetNotes.ts b/src/core/services/ProjectSnippetNotes.ts
@@ -2,7 +2,7 @@ import { ResourceNotes } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectSnippetNotes extends ResourceNotes {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', 'snippets', options);
   }
 }
diff --git a/src/core/services/ProjectVariables.ts b/src/core/services/ProjectVariables.ts
@@ -2,7 +2,7 @@ import { ResourceVariables } from '../templates';
 import { BaseServiceOptions } from '../infrastructure';
 
 export class ProjectVariables extends ResourceVariables {
-  constructor(options: BaseServiceOptions = {}) {
+  constructor(options: BaseServiceOptions) {
     super('projects', options);
   }
 }
diff --git a/src/core/services/ProtectedTags.ts b/src/core/services/ProtectedTags.ts
@@ -7,13 +7,13 @@ import {
 } from '../infrastructure';
 
 export class ProtectedTags extends BaseService {
-  all(projectId: string | number, options: PaginatedRequestOptions) {
+  all(projectId: string | number, options?: PaginatedRequestOptions) {
     const pId = encodeURIComponent(projectId);
 
     return RequestHelper.get(this, `projects/${pId}/protected_tags`, options);
   }
 
-  protect(projectId: string | number, tagName: string, options: BaseRequestOptions) {
+  protect(projectId: string | number, tagName: string, options?: BaseRequestOptions) {
     const pId = encodeURIComponent(projectId);
 
     return RequestHelper.post(this, `projects/${pId}/protected_tags`, {
@@ -22,13 +22,13 @@ export class ProtectedTags extends BaseService {
     });
   }
 
-  show(projectId: string | number, tagName: string, options: Sudo) {
+  show(projectId: string | number, tagName: string, options?: Sudo) {
     const [pId, tName] = [projectId, tagName].map(encodeURIComponent);
 
     return RequestHelper.get(this, `projects/${pId}/protected_tags/${tName}`, options);
   }
 
-  unprotect(projectId: string | number, tagName: string, options: Sudo) {
+  unprotect(projectId: string | number, tagName: string, options?: Sudo) {
     const [pId, tName] = [projectId, tagName].map(encodeURIComponent);
 
     return RequestHelper.del(this, `projects/${pId}/protected_tags/${tName}`, options);

diff --git a/src/core/services/PushRules.ts b/src/core/services/PushRules.ts
@@ -7,7 +7,7 @@ export class PushRules extends BaseService {
     return RequestHelper.post(this, `projects/${pId}/push_rule`, options);
   }
 
-  edit(projectId: string | number, options: BaseRequestOptions) {
+  edit(projectId: string | number, options?: BaseRequestOptions) {
     const pId = encodeURIComponent(projectId);
 
     try {