Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons need border-radius: 0 for hard rectangle edge #3

Closed
rogerclark opened this issue Apr 22, 2020 · 4 comments
Closed

Buttons need border-radius: 0 for hard rectangle edge #3

rogerclark opened this issue Apr 22, 2020 · 4 comments
Labels
good first issue Good for newcomers

Comments

@rogerclark
Copy link

The Windows Classic style UIs don't have rounded rectangles. On at least Chrome and Edge Preview, you need border-radius: 0 to achieve the hard edges.
@jdan
Copy link
Owner

jdan commented Apr 22, 2020

Thanks for reporting! Mind including a screenshot?

@pluma
Copy link

pluma commented Apr 22, 2020 •
edited

Default:
image

With radius zero:
image

(this is with the new Edge, which is Chromium based)

@jdan
Copy link
Owner

jdan commented Apr 22, 2020

Awesome, thank ya! Will leave this one open if anyone's keen on sending a PR.

@jdan jdan added the good first issue Good for newcomers label Apr 22, 2020
@mattbegent mattbegent mentioned this issue Apr 22, 2020
Merged
@TheBox193 TheBox193 mentioned this issue Apr 22, 2020
Closed
@jdan
Copy link
Owner

jdan commented Apr 22, 2020

Fixed via #22

@jdan jdan closed this as completed Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rogerclark @jdan @pluma