formatting issues with embedded semi-colons

[pmackay]

A site config that included this:

add_header X-Xss-Protection "1; mode=block" always

was making the formatting look odd because of the semi-colon in the middle of the statement. In the replace I tried adding a newline to match on the end of the line, e.g.

v.replace(";\n",";\n ")

which worked but its not a complete fix. Perhaps a regex match to end of line including any preceeding whitespace would work. Do you think this would be a useful fix?

[jdauphant]

You have alternative notation that should work in theses cases :
https://github.com/jdauphant/ansible-role-nginx/releases/tag/v1.2

[andrenarchy]

It's not just a cosmetic problem: we ran into the same issue and our site wasn't reachable at all with firefox because headers with newlines are disallowed in http2 (see here and here).

@jdauphant: Why does the nginx role modify the strings at all? Wouldn't it be better to just remove the manipulations?

[nschloe]

+1
Here are more details about the spec: http://stackoverflow.com/a/31324422/353337.

[jdauphant]

@andrenarchy Have you see the new notation ? (https://github.com/jdauphant/ansible-role-nginx/releases/tag/v1.2 )
The new notation is not cosmetic, it doesn't edit string at all (except spacing after new line : https://github.com/jdauphant/ansible-role-nginx/blob/master/templates/site.conf.j2#L5).

Old notation are just keeped has compatibility

[nschloe]

Old notation are just keeped has compatibility

Considering this bug, I guess removing the old, buggy notation and bumping the major version would be a sensible thing to do.

[andrenarchy]

@jdauphant Yes, it works with the "new notation". The question is: why should these strings be modified at all? Removing the string modifications wouldn't break compatibility – it would increase compatibility because it doesn't break headers anymore (and probably other settings).

[jdauphant]

@nschloe I was thinking about that the time when I introduce the notation.
It's a good idea.
@andrenarchy The string modification are here only to provide readable files, it's debatable some people want other doesn't want that. But if we remove old notation to replace by the new notation, we can provide both.

[jdauphant]

If someone want to push a PR that remove old syntax and promote the new syntax, I will be happy to merge :)