Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editor:fold-selection fired on ctrl-alt-f instead of jsformat:format #52

Open
miklen opened this issue May 11, 2015 · 5 comments
Open

Comments

@miklen
Copy link

miklen commented May 11, 2015

When I try to do 'ctrl-alt-f' Atom will prioritize 'editor:fold-section' instead of jsformat:format. I've tried this in JS files and LESS files. Same thing happens. When I do Ctrl+. to see keybinds I clearly see that 'editor:fold-selection' is being used instead of 'jsformat:format', which is listed as second priority.

Atom version 0.198.0
JSFormat verson: 0.8.0

@ilanbiala
Copy link
Collaborator

@miklen can't you change JSFormat's keybinding? Do you have a recommendation for a new one?

@miklen
Copy link
Author

miklen commented May 18, 2015

@ilanbiala I guess I can change it to something else if needed. I've been using JSFormat for Sublime Text 3, and it also uses ctrl+alt+f. I can see that it's supposed to work with ctrl+alt+f in Atom as well, but apparently 'editor:fold-section' takes precedence because it's more specific in where it's supposed to be used (that's how I understood my very brief look at Atom keybindings.

Is there a way to make JSFormat take precedence, other than rebinding it?

@miklen
Copy link
Author

miklen commented May 18, 2015

I made it work by binding it to ctrl+alt+f again like this:

'atom-workspace atom-text-editor:not([mini])':
  'ctrl-alt-f': 'jsformat:format'

@ilanbiala
Copy link
Collaborator

@miklen can you submit a PR for this?

@miklen
Copy link
Author

miklen commented May 21, 2015

Done #56

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants