Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

module-info.java #101

Closed
cowwoc opened this issue Oct 1, 2023 · 2 comments
Closed

module-info.java #101

cowwoc opened this issue Oct 1, 2023 · 2 comments
Assignees
Milestone

Comments

@cowwoc
Copy link

cowwoc commented Oct 1, 2023

Please add Java9+ support by adding module-info.java to this library.

Using the multi-release JAR approach, you can maintain backwards compatibility to older versions of Java. See the multiReleaseOutput property in https://www.baeldung.com/maven-multi-release-jars for the easiest way to proceed.

@ttddyy
Copy link
Member

ttddyy commented Oct 4, 2023

Hi, I'll add Automatic-Module-Name entry.

For multi version support, currently datasource-proxy supports java6 and up.
It wouldn't be a good fit to support a wide range of new language features available in the newer java versions.
I'll rather take a baseline upgrade in the next major version of datasource-proxy(TBD).

@ttddyy ttddyy added this to the 1.10 milestone Oct 4, 2023
@ttddyy ttddyy self-assigned this Oct 4, 2023
@ttddyy ttddyy closed this as completed in fd6c08a Oct 4, 2023
@cowwoc
Copy link
Author

cowwoc commented Oct 5, 2023

Hi @ttddyy

Can you please elabroate? What's the problem with adding META-INF/versions/9/module-info.class? This won't break anything for anyone using older versions of Java.

Unfortunately, automatic modules are not equivalent to full-fledged modules. They trigger warnings when building Maven and cannot be used with jlink, etc.

Let me know about the above question. Hopefully we can find a way forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants