Skip to content

Commit

Permalink
Require a minimum of R 3.3.0.
Browse files Browse the repository at this point in the history
  • Loading branch information
jdblischak committed Dec 29, 2020
1 parent fb307bf commit af1bed4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
Expand Up @@ -33,7 +33,7 @@ Description: Provides a workflow for your analysis projects by combining
URL: https://github.com/jdblischak/workflowr
BugReports: https://github.com/jdblischak/workflowr/issues
Depends:
R (>= 3.2.5)
R (>= 3.3.0)
License: MIT + file LICENSE
Encoding: UTF-8
LazyData: true
Expand Down
5 changes: 5 additions & 0 deletions NEWS.md
Expand Up @@ -53,6 +53,11 @@ load code defined in a `.Rprofile` file (idea from @pcarbo).
syntax to insert icons into the navigation bar when a recent version of
rmarkdown is installed (>= 2.6) (bug report from @christianholland, #231)

* Bump minimum required version of R from 3.2.5 to 3.3.0. While workflowr itself
should be able to continue to work fine with R 3.2.5, it was becoming too much
of a burden to regularly test workflowr with R 3.2.5 as the tidyverse team has
started updating their packages to require a minimum of R 3.3.0.

# workflowr 1.6.2

This patch release of workflowr includes minor improvements, updated
Expand Down
11 changes: 3 additions & 8 deletions tests/testthat/test-wflow_publish.R
Expand Up @@ -342,14 +342,9 @@ test_that("wflow_publish restores previous docs/ if build fails", {
md5sum_post <- tools::md5sum(html)
mtime_post <- file.mtime(html)
expect_identical(md5sum_post, md5sum_pre)
# expect_identical(mtime_post, mtime_pre)
# The test above failed R CMD check when testing with R 3.2.5. They aren't
# identical due too crazy small rounding errors:
# > mtime_post - mtime_pre
# Time differences in secs
# [1] -1.907349e-06 -9.536743e-07 -9.536743e-07
# So instead I check with all.equal() and reduntantly with my own similiar
# test of the time difference (much less than the time it slept above).
expect_identical(mtime_post, mtime_pre)
# In case the above test fails due to rounding errors, the following tests
# ensure that the modification times are essentially identical.
expect_equal(mtime_post, mtime_pre)
expect_true(all(mtime_post - mtime_pre < 0.1))
})
Expand Down

0 comments on commit af1bed4

Please sign in to comment.