Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin failure on Windows #4

Open
rippling-rsistla opened this issue Mar 17, 2016 · 4 comments
Open

Plugin failure on Windows #4

rippling-rsistla opened this issue Mar 17, 2016 · 4 comments

Comments

@rippling-rsistla
Copy link

The directory-maven-plugin plugin was failing for me on my Windows machine with the error "Cannot find a single highest directory for this project set": . I looked into the plugin code and investigated this further. The failure happened on HighestBasedirGoal.java: 109.

The issue seems to be due my windows environment. If I do:
cd c:\src\git\repo
mvn clean install

the maven plugin fails. If I do

cd C:\src\git\repo (note the case sensitivity of c)
mvn clean install

the maven command succeeds. Could this be due to a bug in the plugin? Instead of startsWith or String's compareTo, using File's compareTo - might have solved this issue.

@jdcasey
Copy link
Owner

jdcasey commented Mar 23, 2016

I don't have a windows machine on which to test. Do you have any interest in making that change and testing to see if it works? If so, I'd be happy to look over a PR and probably merge / re-release.

@ilya-g
Copy link

ilya-g commented Mar 29, 2016

I confirm I can reproduce this too, with the exactly same steps: by invoking maven from current directory starting with a lowercase drive letter.

Also, I find the error message quite uninformative: it states that "First two candidates directories don't share a common root." but does not tell which are those two candidates.

@hazendaz
Copy link

seems odd, haven't seen the issue but windows doesn't directly care about case, using git bash possibly?

@hazendaz
Copy link

seems fixed in 2017 at a7cc705 and probably should be closed as a result.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants