Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: userdefined tradingday variables with withspaces aren't saved/loaded correctly #425

Open
Immurb opened this issue Sep 27, 2018 · 3 comments
Assignees
Labels

Comments

@Immurb
Copy link
Member

Immurb commented Sep 27, 2018

If you have a variable list or a variable with withspaces in the name and use it as userdefined tradingday regressor it will be saved/loaded like multiple regressors.
For example "Vars -1.x _1" would be loaded as 3 regressors with the names "Vars", "-1.x" and "_1".

@charphi charphi added the bug label Oct 4, 2018
@charphi charphi self-assigned this Oct 4, 2018
@charphi
Copy link
Contributor

charphi commented Oct 4, 2018

It seems that the vars are properly saved in the xml workspace. The bug arises in the GUI.

vars with white spaces

@Immurb
Copy link
Member Author

Immurb commented Oct 4, 2018

I think the problem lies with the loading itself, because it uses whitespace as separator in String arrays. So 2 variables look exactly like one variable with one whitespace in a saved workspace.
A possible fix could be to save them like user defined regressors but it would result in additional overhead and you need an implementation for "legacy" workspaces (aka 2.2.1 and lower).

@charphi
Copy link
Contributor

charphi commented Oct 4, 2018

You are right. The problem comes from the loading of the xml.
More specificaly: ec.tss.xml.XmlStrings.

It is difficult to make changes without breaking backward compatibility.
So, Jean suggests to alter the GUI to prevent names from using whitespace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants