Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lodash dependency not strict enough #206

Closed
vdust opened this issue Dec 7, 2015 · 2 comments
Closed

lodash dependency not strict enough #206

vdust opened this issue Dec 7, 2015 · 2 comments

Comments

@vdust
Copy link

vdust commented Dec 7, 2015

In package.json, the lodash dependency is set to "*".

Upon installing a project that depends on connect-mongo, i ran into a missing symbol issue ( _.assign is not a function ). The issue ended up being caused by lodash 0.9.2 that was installed as the top-level version (and satisfied the loose dependency)... But this version doesn't have lodash.assign. Forcing a dependency on lodash^3.0.0 in this other project fixed the issue, but since it doesn't use it directly, i should not have to do that.

lodash dependency should be set to at least ">=3.0.0" (older versions are deprecated and no longer maintained so there is no reason to accept them as dependencies in new releases).

@vdust
Copy link
Author

vdust commented Dec 8, 2015

I just noticed that this issue would be fixed by merging the pull request #204.

@jdesboeufs
Copy link
Owner

Fixed in 1.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants