Fix overwriting of session.cookie, change tests to use uniform data with real cookie instance #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N for cookie, change tests to use uniform session data and validation. Fixes jdesboeufs#76
…de nested objects
|
Does this fixed the bug mentioned by@mmagi in #63 ( The most current npm version (0.3.3) is broken, so I would love to see this merged and pushed to npm asap. |
|
@lukaszfiszer Yes, it fixes that bug (which one of my previous PRs introduced). See #76 for more info. |
|
Great! Thank for info |
kcbanner
added a commit
that referenced
this pull request
Jul 23, 2013
Fix overwriting of session.cookie, change tests to use uniform data with real cookie instance
|
Thanks for this. I'll bump the version and publish soon. |
|
@kcbanner, can you bump the version and publish this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #76 by making the default
_serialize_sessionfunction copy session properties to a new object and handle converting the cookie instance to an object without changing the original session.In addition, tests have been changed to use uniform test data that includes an instance of
connect.session.Cookieand each test now checks for deep equality between the input data and the session data in a more consistent fashion. This makes tests more real-world as the data is more representative of actual data that will be encountered.