Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add names and colormaps (via LayerDataTuple) to the output layers #9

Merged
merged 1 commit into from May 5, 2022

Conversation

psobolewskiPhD
Copy link
Collaborator

The plugin implements 3 different decompositions. Applying colormaps to the output decompositions makes them easier to interpret (and stand out more vs. the data).
PCA and ICA return both positive and negative values, so it makes sense to visualize using a diverging colormap. napari implements PiYG, which is colorblind-safe, so that one is used by default.
NMF specifically does not return negative values, so viridis a uniform, colorblind-safe colormap is used by default.
Also, the layers are named explicitly.

@zoccoler
Copy link
Owner

zoccoler commented May 3, 2022

Hi Peter @psobolewskiPhD,

This implementation make total sense to me, good idea!
I also like the flexibility of the LayerDataTuple return annotation.
I can confirm the changes work here.

Best,
Marcelo

@jdeschamps jdeschamps merged commit 9ad3e94 into main May 5, 2022
@psobolewskiPhD psobolewskiPhD deleted the feature/apply_PiYG_colormap branch May 5, 2022 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants