Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the combinatorial optimisation feature as an optional dependency #51

Merged
merged 12 commits into from
Apr 21, 2015

Conversation

willu47
Copy link
Member

@willu47 willu47 commented Apr 21, 2015

Includes:

NB, supersedes #50 which should be closed without merging

@coveralls
Copy link

Coverage Status

Coverage decreased (-5.75%) to 87.24% when pulling dc7d53b on willu47:feat_gurobi into 3362b90 on jdherman:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage decreased (-5.75%) to 87.24% when pulling dc7d53b on willu47:feat_gurobi into 3362b90 on jdherman:master.

@jdherman
Copy link
Member

Really nice!! So if I understand this right:

  • The option for optimization doesn't affect the current (non-optimized) Morris API
  • gurobipy will not be installed as a dependency automatically, for example when running pip install SALib. People using it will need to install it separately.
  • Travis CI will skip the Gurobi tests

Is this right? Again this is great, it's nice to have the option for optimized trajectories.

@willu47
Copy link
Member Author

willu47 commented Apr 21, 2015

Yep, that's all correct. Unfortunately, gurobi has to be installed manually. If use is for academic research, it's easy to get a free academic license.

jdherman added a commit that referenced this pull request Apr 21, 2015
Adds the combinatorial optimisation feature as an optional dependency
@jdherman jdherman merged commit d687e72 into SALib:master Apr 21, 2015
@jdherman
Copy link
Member

That's fine, it's better than having no optimizer at all, and it's clearly optional. Plus this addresses some of the long-standing issues, so thanks again!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants