Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peekview keyword has no highlight group. #20

Closed
serend1p1ty opened this issue Aug 1, 2019 · 10 comments
Closed

Peekview keyword has no highlight group. #20

serend1p1ty opened this issue Aug 1, 2019 · 10 comments

Comments

@serend1p1ty
Copy link

image
Now it's default ugly red.

@jdinhify
Copy link
Owner

jdinhify commented Aug 2, 2019

Thanks for reporting this @ppnman 👌
I don't use peekView often though, so not sure what would be the best background, would you be able to suggest a colour?

@serend1p1ty
Copy link
Author

image
What do you think of the color(#ac6913) ?
image
Or this(#23395C)?
Or you can reference other colortheme.
BTW, your gruvbox colorscheme is great, I love it!

@serend1p1ty
Copy link
Author

BTW, I suggest that the foreground of the item seleceted should be lighter than other entries.
Like this:
(Solarized Dark)
image
Now it is darker than other entries.
(Gruvbox Medium)
image

@serend1p1ty
Copy link
Author

serend1p1ty commented Aug 2, 2019

@jdinhify So the final effect is:
image

// PEEK VIEW
    "peekView.border": "#3c3836",
    "peekViewEditor.background": "#3c383650",
    "peekViewEditorGutter.background": "#3c383650",
    "peekViewEditor.matchHighlightBackground": "#ac6913", #Modified
    "peekViewResult.background": "#3c383650",
    "peekViewResult.fileForeground": "#ebdbb2",
    "peekViewResult.matchHighlightBackground": "#8ec07c30",
    "peekViewResult.selectionBackground": "#8ec07c30",
    "peekViewResult.selectionForeground": "#FFFFFF", #Modified
    "peekViewTitle.background": "#3c383650",
    "peekViewTitleDescription.foreground": "#bdae93",
    "peekViewTitleLabel.foreground": "#ebdbb2",

@jdinhify
Copy link
Owner

jdinhify commented Aug 3, 2019

thanks @ppnman, the color look cool, but I think it's better to stick with the colors in gruvbox palette, would you be able to give the colors.txt a try https://github.com/jdinhify/vscode-theme-gruvbox/blob/master/colors.txt

try

"peekViewEditor.matchHighlightBackground": "#fe801980",
"peekViewResult.selectionForeground": "#fbf1c7"

note that you can use 2 chars (00 -> ff) after the color code to specify the alpha, eg. #fe801980 is the orange 2 in colors.txt (fe8019) with 80 as alpha

@serend1p1ty
Copy link
Author

@jdinhify Very good, I like it.
image

@jdinhify
Copy link
Owner

jdinhify commented Aug 5, 2019

Thanks @ppnman , would you be able to submit a PR for it? I'm happy to do it if you can't.

It'd be great if you can do for other variants, but no pressure, I can have a follow up commit to address other variants

@serend1p1ty
Copy link
Author

serend1p1ty commented Aug 8, 2019

@jdinhify
I am really sorry that I just saw your reply. There are so many things going on there days so that I have no time to browse GitHub.
Of course, I am glad to submit a PR for it. But maybe it takes one week to finish it because I need to consider what color is better in light colorscheme.

@jdinhify
Copy link
Owner

jdinhify commented Aug 9, 2019

That's alright @ppnman , please take as much time as you need.

Thank you

@serend1p1ty
Copy link
Author

I am sorry to close the issue because I don't use vscode anymore.
BTW, both the plugin and author are great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants