Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket pair colouriser support #43

Closed
johannesrld opened this issue Sep 5, 2021 · 4 comments
Closed

Bracket pair colouriser support #43

johannesrld opened this issue Sep 5, 2021 · 4 comments

Comments

@johannesrld
Copy link

johannesrld commented Sep 5, 2021

vscode recently introduced editor.bracketPairColorization.enabled as an option (check this update)

these can be customised with the settings editorBracketHighlight.foregroundx with the trailing x being replace by the numbers 1-6 and editorBracketHighlight.unexpectedBracket.foreground for singular brackets not in a pair

@jdinhify
Copy link
Owner

jdinhify commented Oct 5, 2021

Thanks @tauin

I'm curious what sort of colours would you use. Obviously they should be in the gruvbox palette (https://github.com/morhetz/gruvbox), but the question is more about the brightness: if you're using dark mode, would you use the same or darker colours for the brackets?

@Tuuuukka
Copy link

I've been using these for the Gruvbox Dark Medium for a while now:

    // BRACKETS
    "editorBracketHighlight.foreground1": "#fabd2f",
    "editorBracketHighlight.foreground2": "#d3869b",
    "editorBracketHighlight.foreground3": "#83a598",
    "editorBracketHighlight.foreground4": "#b8bb26",
    "editorBracketHighlight.foreground6": "#8ec07c",
    "editorBracketHighlight.unexpectedBracket.foreground": "#fb4934"

image

Don't know if they're perfect, but working ok for me (I do mostly JS, TS, and PHP). What @jdinhify said about the brightness is something to consider. If the palette would have even brighter colors than these, I'd use them to kind of highlight the brackets a little and make them stand out from the rest of the code. But that's a personal preference. Using darker colors makes them kinda hard to read for me, but it's also something you might get used to.

Why I'm used to brighter ones is probably because I used the VSCode default ones for quite some time as I was too lazy to change them 😄

@shpigunov
Copy link
Contributor

Here is my proposal. #54 You can read the reasoning behind specific decisions in the PR. I will be happy to answer any questions.

@jdinhify
Copy link
Owner

Merged & deployed #54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants