Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any plans for a light version? #6

Closed
josebalius opened this issue Jan 28, 2018 · 5 comments
Closed

Any plans for a light version? #6

josebalius opened this issue Jan 28, 2018 · 5 comments

Comments

@josebalius
Copy link

Are there any plans to do a light version?

@jdinhify
Copy link
Owner

Thanks Jose. I did have different versions in mind, but never got time around to try the light version and make one variant for it. Also I'm not using light version full time so I might not be the best one to implement it.
The thing I had in mind was just replacing the dark colors with their corresponding light colors and hope it'll turn out alright.

Perhaps I can draft up something on the weekend and see how it goes. I'm assuming you're talking about a medium contrast theme? I'll want to make a proper one first, then the other variants will just be replacing the background colors

@jdinhify
Copy link
Owner

jdinhify commented Feb 4, 2018

New version published with my rough draft of light versions. Please try them and let me know if there's any suggestion, or if you want to contribute.

Thank you!

@jdinhify jdinhify closed this as completed Feb 4, 2018
@josebalius
Copy link
Author

@jdinhify I will take it for a spin this week, thank you!!!

@josebalius
Copy link
Author

@jdinhify So far it looks perfect, thank you again. Noticed that its missing the background color for non-selected tabs.

Here is a screenshot, I can submit a PR but not sure which setting in vscode controls this:

screen shot 2018-02-05 at 9 50 49 am

@jdinhify
Copy link
Owner

jdinhify commented Feb 5, 2018

Thanks @josebalius , I noticed that too but wasn't sure which setting either, I'll have a look into vscode doco and fix it when I have time. But of course, if you found the setting and could submit a PR, it'd be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants