Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt a message if an error occurs? #78

Closed
bsaby opened this issue Feb 5, 2018 · 3 comments · Fixed by #88
Closed

Prompt a message if an error occurs? #78

bsaby opened this issue Feb 5, 2018 · 3 comments · Fixed by #88
Assignees
Milestone

Comments

@bsaby
Copy link

bsaby commented Feb 5, 2018

The current behavior is that the extension will not be forced to jump to the checkstyle output channel when an error occurs.

Enhancements:
Currently, If the checkstyle output channel is not open, prompt a message:

  1. Tell user that an error occurred
  2. Provide a checkstyle output channel entry and ask the user if open it.
@jdneo jdneo added this to the Backlog milestone Feb 8, 2018
@jdneo
Copy link
Owner

jdneo commented Feb 8, 2018

This is a great suggestion. Let me think about how should the extension pop up the error hint.

@jdneo
Copy link
Owner

jdneo commented Feb 8, 2018

Current thinking about this:

The checkstyle status icon will have three status:

  • X: has checkstyle error
  • ✔️: no checkstyle error
  • ⚠️: Something error occurred on checkstyle language server

@jdneo
Copy link
Owner

jdneo commented Feb 12, 2018

In #88, we change the status icon into 4 state:

  • ✔️ No Checkstyle error, click it will open the output channel.
  • 🐞 Has Checkstyle error, click it will open the output channel.
  • ⚠️ Language server error, click it will open the output channel.
  • ✏️ Wait for check, click it will trigger the command check code with Checkstyle.

@bsaby for awareness

@jdneo jdneo mentioned this issue Feb 12, 2018
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants