Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I could not find leetcode:test #15

Closed
karangoel16 opened this issue Mar 4, 2018 · 7 comments · Fixed by #16
Closed

I could not find leetcode:test #15

karangoel16 opened this issue Mar 4, 2018 · 7 comments · Fixed by #16
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@karangoel16
Copy link

If possible please add Test module in your plugin as well, this will be of real help.

@jdneo
Copy link
Member

jdneo commented Mar 5, 2018

@karangoel16 Yes, actually I'm also thinking to add this.

The problem is about the experience.

My idea is:

  1. User writes test case into a txt
  2. User triggers the test command
  3. Extension asks user to select the test case file
  4. Extension uploads the test case and shows the result

What do you think? Please feel free to provide your ideas. 😄

@jdneo jdneo self-assigned this Mar 5, 2018
@jdneo jdneo added this to the 0.3.0 milestone Mar 5, 2018
@jdneo jdneo added the enhancement New feature or request label Mar 5, 2018
@karangoel16
Copy link
Author

I like the idea, but as leetcode-cli works, we can make it work for user given test case.

@jdneo
Copy link
Member

jdneo commented Mar 5, 2018

@karangoel16 Yes, that's actually what I'm saying. User can write their own test cases into a file, and we upload this file.
As long as the user know the format for test cases.

I guess we are in consensus, right?

@jdneo
Copy link
Member

jdneo commented Mar 5, 2018

@karangoel16 Sorry, just take a look at the cli usage. Do you mean besides the user writen test case, also provide the default test case as well?

@karangoel16
Copy link
Author

leetcode test 378.kth-smallest-element-in-a-sorted-matrix.cpp -t '[[1,5,9],[10,11,13],[12,13,15]]\n8'

user can paste this '[[1,5,9],[10,11,13],[12,13,15]]\n8' in command section and following would run like it runs with the normal leetcode test scenario.

@jdneo
Copy link
Member

jdneo commented Mar 5, 2018

Make sense, this will be more straightforward for simpler cases.

Thanks for the feedback, I'll implement this feature these days.

@jdneo
Copy link
Member

jdneo commented Mar 5, 2018

New version released. Please try it out 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants