Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using webview to show the result #76

Closed
jdneo opened this issue Dec 6, 2018 · 2 comments
Closed

Using webview to show the result #76

jdneo opened this issue Dec 6, 2018 · 2 comments
Labels
enhancement New feature or request
Milestone
0.9.0

Comments

@jdneo
Copy link
Member

jdneo commented Dec 6, 2018

No description provided.

@jdneo jdneo added the bug Something isn't working label Dec 6, 2018
@jdneo jdneo added this to the 0.8.2 milestone Dec 6, 2018
@jdneo jdneo changed the title The Result page will not be updated if user edited it. Using webview to show the result Jan 6, 2019
@jdneo jdneo added enhancement New feature or request and removed bug Something isn't working labels Jan 6, 2019
@jdneo jdneo modified the milestones: 0.8.2, 0.8.3 Jan 6, 2019
@jdneo jdneo mentioned this issue Jan 13, 2019
Merged
@jdneo jdneo closed this as completed in #89 Jan 13, 2019
@twchn
Copy link

twchn commented Jan 23, 2019

What is the purpose of doing this, I can not see the history result by command + Z now 😥

@jdneo
Copy link
Member Author

jdneo commented Jan 23, 2019

@taoweicn

Hmm, That's a good question. The original implementation is to save the output into a file called .Result, so you can see the previous result by entering command + z.

But this may cause other problems, for example, if a user edits the .Result file unintentionally and doesn't save his change, then the result file could never be updated. This is the behavior of VS Code and we could do nothing with it.

Well, using web view could avoid this bug.

We might need to think if there is any other better way to show the previous result. For now there is a workaround, that is check the output in the extension's output channel, which is named as LeetCode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
0.9.0
Development

No branches or pull requests
2 participants
@jdneo @twchn