Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImageSpecField does not work in abstract base class #126

Closed
vesterbaek opened this issue Apr 10, 2012 · 1 comment
Closed

ImageSpecField does not work in abstract base class #126

vesterbaek opened this issue Apr 10, 2012 · 1 comment

Comments

@vesterbaek
Copy link

Signals are registered on the class name:
https://github.com/jdriscoll/django-imagekit/blob/develop/imagekit/models/fields/__init__.py#L95-100

When an ImageSpecField is defined in an abstract model, the signals never get triggered when the superclass is e.g. saved. I'm using the NonValidatingImageCacheBackend, and am hence quite dependent on the triggering of the signals.

@matthewwithanm
Copy link
Owner

This is definitely a problem, but I'm not entirely sure how we should approach it. It seems like a Django bug and there's currently an open ticket to address it. I'm open to suggestions though.

matthewwithanm added a commit that referenced this issue Feb 10, 2013
Includes a fix for undispatched signals, as well as signals being
handled twice.

A regression of #126
Related: #185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants